-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Expand test coverage for pkg/util/compression
#45534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
blt
wants to merge
2
commits into
main
Choose a base branch
from
01-27-expand_test_coverage_for_pkg_util_compression_
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Go Package Import DifferencesBaseline: 8766844
|
This commit is motivated by the potential end state in spike PR #45519. That is, if we want to make non-trivial changes to this package systematic testing of the package is warranted. I have introduced tests to confirm that for all the strategies supported by this package: - the identity `b == decompress(compress(b))` holds * that this is true also for zstd cgo/nocgo crossed - empirical confirmation of the `CompressBound` calculations - tests for resource management by the streaming compression This commit includes fixes for the following: - zlib CompressBound: Changed from 13 to 16 bytes overhead - gzip CompressBound: Changed from 18 to 33 bytes overhead - zstd CGO: Fixed write-after-close bug by adding a wrapper with state tracking Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
Signed-off-by: Brian L. Troutwine <brian.troutwine@datadoghq.com>
dab3839 to
ab6aa69
Compare
Contributor
Static quality checks❌ Please find below the results from static quality gates Error
Gate failure full details
Static quality gates prevent the PR to merge! Successful checksInfo
12 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

What does this PR do?
This commit is motivated by the potential end state in spike PR #45519.
That is, if we want to make non-trivial changes to this package systematic
testing of the package is warranted. I have introduced tests to confirm that
for all the strategies supported by this package:
b == decompress(compress(b))holdsCompressBoundcalculationsThis commit includes fixes for the following: