add direct send loop #45193
Open
add direct send loop #45193
+2,518
−207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/system-probe
long review
Contributor
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 19 | 0 | 0 |
ℹ️ Diff available in the job log.
brycekahle
added
changelog/no-changelog
qa/done
Contributor
Go Package Import DifferencesBaseline: d8f3269
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: d8f3269 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -0.30 | [-3.35, +2.75] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +1.82 | [+0.29, +3.34] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +1.23 | [+1.18, +1.28] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.59 | [+0.55, +0.63] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_memory | memory utilization | +0.35 | [+0.27, +0.42] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.10 | [-0.13, +0.33] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.09 | [+0.04, +0.15] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.08 | [-0.34, +0.50] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.14, +0.16] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.07, +0.09] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.00 | [-0.09, +0.10] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.02 | [-0.06, +0.03] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.15, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.03 | [-0.08, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.03 | [-0.42, +0.36] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | -0.06 | [-0.12, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.07 | [-0.57, +0.43] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.08 | [-0.24, +0.08] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.08 | [-0.27, +0.11] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.19 | [-0.41, +0.03] | 1 | Logs |
| ➖ | docker_containers_cpu | % cpu utilization | -0.30 | [-3.35, +2.75] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.42 | [-0.59, -0.26] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.48 | [-0.55, -0.41] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | -2.31 | [-2.53, -2.09] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
13 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
brycekahle
force-pushed
the
bryce.kahle/cnm-direct-send
branch
5 times, most recently
from
02f4b7f to
6d3b1c3
Compare
3 tasks
brycekahle
force-pushed
the
bryce.kahle/cnm-direct-send
branch
from
6d3b1c3 to
05122d0
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05122d03e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
brycekahle
force-pushed
the
bryce.kahle/cnm-direct-send
branch
from
05122d0 to
8dcbc96
Compare
dustmop
approved these changes
Jan 29, 2026
Contributor
dustmop
left a comment
dustmop
left a comment
There was a problem hiding this comment.
LGTM for agent-configuration owned files
AlexandreYang
approved these changes
Jan 30, 2026
Member
AlexandreYang
left a comment
AlexandreYang
left a comment
There was a problem hiding this comment.
LGTM for files owned by network-path
jmw51798
requested review from
jmw51798
and removed request for
charan-manjunath
gjulianm
approved these changes
Jan 30, 2026
jmw51798
reviewed
Jan 30, 2026
jmw51798
reviewed
Jan 30, 2026
jmw51798
reviewed
Jan 30, 2026
jmw51798
reviewed
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a loop that collects CNM/USM data to send directly to the backend in system-probe. This is controlled by
network_config.direct_sendwhich is still defaulting tofalsefor now.Motivation
Eventual remove of process-agent on Linux for simplification and memory usage improvements.
We should reduce memory by:
Describe how you validated your changes
Added regular tests and an E2E test.
Additional Notes
Supporting refactoring work was done in previous PRs.