Skip to content

Conversation

@remeh
Copy link
Contributor

@remeh remeh commented Jul 29, 2025

What does this PR do?

Avoid a panic when the unit test fails by bailing out earlier.

@remeh remeh requested a review from a team as a code owner July 29, 2025 12:26
@remeh remeh added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Jul 29, 2025
@remeh remeh changed the title dogstatsd/listeners: fail gracefully on nil connection in TestNewUDPL… dogstatsd/listeners: fail gracefully on nil connection in TestNewUDPListenerWhenBusyWithSoRcvBufSet Jul 29, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Jul 29, 2025
@remeh
Copy link
Contributor Author

remeh commented Jul 29, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Jul 29, 2025

View all feedbacks in Devflow UI.

2025-07-29 12:33:39 UTC ℹ️ Start processing command /merge


2025-07-29 12:33:49 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-07-29 16:34:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@cit-pr-commenter
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 4a337809-6f49-4834-9821-a3ce025f07da

Baseline: c6aaf97
Comparison: f610d4b
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -1.60 [-4.61, +1.41] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.18 [+1.11, +1.24] 1 Logs
otlp_ingest_metrics memory utilization +0.35 [+0.21, +0.49] 1 Logs
quality_gate_logs % cpu utilization +0.27 [-2.47, +3.02] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.06 [+0.00, +0.11] 1 Logs bounds checks dashboard
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.56, +0.66] 1 Logs
ddot_logs memory utilization +0.01 [-0.08, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.32, +0.31] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.65, +0.62] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.08 [-0.67, +0.51] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.08 [-0.68, +0.52] 1 Logs
quality_gate_idle memory utilization -0.12 [-0.20, -0.04] 1 Logs bounds checks dashboard
ddot_metrics memory utilization -0.15 [-0.26, -0.03] 1 Logs
docker_containers_memory memory utilization -0.18 [-0.26, -0.10] 1 Logs
otlp_ingest_logs memory utilization -0.27 [-0.39, -0.14] 1 Logs
file_tree memory utilization -0.42 [-0.46, -0.37] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.46 [-0.50, -0.42] 1 Logs
quality_gate_metrics_logs memory utilization -0.47 [-0.86, -0.07] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -1.60 [-4.61, +1.41] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 bounds checks dashboard
quality_gate_metrics_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor c6aaf97

Successful checks

Info

Quality gate Delta On disk size (MiB) Delta On wire size (MiB)
agent_deb_amd64 $${0}$$ $${704.5}$$ < $${704.84}$$ $${+0}$$ $${178.24}$$ < $${178.58}$$
agent_deb_amd64_fips $${0}$$ $${702.76}$$ < $${703.09}$$ $${-0.04}$$ $${177.66}$$ < $${178.12}$$
agent_heroku_amd64 $${0}$$ $${354.7}$$ < $${355.37}$$ $${+0}$$ $${94.91}$$ < $${95.72}$$
agent_msi $${0}$$ $${979.6}$$ < $${979.61}$$ $${+0.05}$$ $${148.77}$$ < $${149.31}$$
agent_rpm_amd64 $${0}$$ $${704.49}$$ < $${704.83}$$ $${+0.02}$$ $${179.83}$$ < $${180.22}$$
agent_rpm_amd64_fips $${0}$$ $${702.75}$$ < $${703.08}$$ $${+0.03}$$ $${179.62}$$ < $${179.85}$$
agent_rpm_arm64 $${0}$$ $${693.4}$$ < $${694.74}$$ $${-0}$$ $${163.21}$$ < $${163.96}$$
agent_rpm_arm64_fips $${0}$$ $${691.7}$$ < $${693.05}$$ $${+0.03}$$ $${162.25}$$ < $${163.0}$$
agent_suse_amd64 $${0}$$ $${704.49}$$ < $${704.83}$$ $${+0.02}$$ $${179.83}$$ < $${180.22}$$
agent_suse_amd64_fips $${0}$$ $${702.75}$$ < $${703.08}$$ $${+0.03}$$ $${179.62}$$ < $${179.85}$$
agent_suse_arm64 $${0}$$ $${693.4}$$ < $${694.74}$$ $${-0}$$ $${163.21}$$ < $${163.96}$$
agent_suse_arm64_fips $${0}$$ $${691.7}$$ < $${693.05}$$ $${+0.03}$$ $${162.25}$$ < $${163.0}$$
docker_agent_amd64 $${-0}$$ $${788.25}$$ < $${788.65}$$ $${-0}$$ $${271.58}$$ < $${272.01}$$
docker_agent_arm64 $${-0}$$ $${800.66}$$ < $${802.0}$$ $${+0}$$ $${258.83}$$ < $${259.7}$$
docker_agent_jmx_amd64 $${+0}$$ $${979.49}$$ < $${979.84}$$ $${+0}$$ $${340.58}$$ < $${340.95}$$
docker_agent_jmx_arm64 $${0}$$ $${980.51}$$ < $${981.8}$$ $${+0}$$ $${323.8}$$ < $${324.65}$$
docker_cluster_agent_amd64 $${+0}$$ $${214.01}$$ < $${214.5}$$ $${+0}$$ $${72.76}$$ < $${73.51}$$
docker_cluster_agent_arm64 $${0}$$ $${229.88}$$ < $${230.33}$$ $${+0}$$ $${69.0}$$ < $${69.77}$$
docker_cws_instrumentation_amd64 $${0}$$ $${7.07}$$ < $${7.12}$$ $${-0}$$ $${2.95}$$ < $${3.29}$$
docker_cws_instrumentation_arm64 $${+0}$$ $${6.69}$$ < $${6.92}$$ $${+0}$$ $${2.7}$$ < $${3.07}$$
docker_dogstatsd_amd64 $${0}$$ $${38.53}$$ < $${39.57}$$ $${+0}$$ $${14.88}$$ < $${15.76}$$
docker_dogstatsd_arm64 $${0}$$ $${37.23}$$ < $${38.2}$$ $${-0}$$ $${14.33}$$ < $${14.83}$$
dogstatsd_deb_amd64 $${0}$$ $${29.77}$$ < $${31.4}$$ $${-0}$$ $${7.85}$$ < $${8.95}$$
dogstatsd_deb_arm64 $${0}$$ $${28.37}$$ < $${29.97}$$ $${+0}$$ $${6.81}$$ < $${7.89}$$
dogstatsd_rpm_amd64 $${0}$$ $${29.77}$$ < $${31.4}$$ $${-0}$$ $${7.86}$$ < $${8.96}$$
dogstatsd_suse_amd64 $${0}$$ $${29.77}$$ < $${31.4}$$ $${-0}$$ $${7.86}$$ < $${8.96}$$
iot_agent_deb_amd64 $${0}$$ $${54.12}$$ < $${54.55}$$ $${-0}$$ $${13.64}$$ < $${14.45}$$
iot_agent_deb_arm64 $${0}$$ $${51.44}$$ < $${51.9}$$ $${+0}$$ $${11.81}$$ < $${12.63}$$
iot_agent_deb_armhf $${0}$$ $${50.95}$$ < $${51.42}$$ $${-0}$$ $${11.88}$$ < $${12.74}$$
iot_agent_rpm_amd64 $${0}$$ $${54.12}$$ < $${54.55}$$ $${+0}$$ $${13.66}$$ < $${14.47}$$
iot_agent_rpm_arm64 $${0}$$ $${51.44}$$ < $${51.91}$$ $${-0}$$ $${11.82}$$ < $${12.65}$$
iot_agent_suse_amd64 $${0}$$ $${54.12}$$ < $${54.55}$$ $${+0}$$ $${13.66}$$ < $${14.47}$$

@dd-octo-sts
Copy link
Contributor

dd-octo-sts bot commented Oct 10, 2025

This pull request has been automatically marked as stale because it has not had activity in the past 15 days.

It will be closed in 30 days if no further activity occurs. If this pull request is still relevant, adding a comment or pushing new commits will keep it open. Also, you can always reopen the pull request if you missed the window.

Thank you for your contributions!

@dd-octo-sts dd-octo-sts bot added the stale label Oct 10, 2025
@gh-worker-devtools-f43747 gh-worker-devtools-f43747 bot deleted the remeh/ut-udp-panic branch January 28, 2026 03:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants