Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paulcacheux/remove kernel check offsets #32442

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 7f64411d20274e2ee9a65e683e9ceda41a5da5ed

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.02MB ⚠️ 1197.23MB 1197.21MB 140.00MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 1197.23MB 1197.21MB 140.00MB
datadog-agent-amd64-deb 0.02MB ⚠️ 1187.96MB 1187.95MB 140.00MB
datadog-heroku-agent-amd64-deb 0.00MB 504.88MB 504.88MB 70.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.57MB 78.57MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.65MB 78.65MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.77MB 55.77MB 10.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.34MB 113.34MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.41MB 113.41MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.80MB 108.80MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 108.87MB 108.87MB 10.00MB
datadog-agent-aarch64-rpm -0.02MB 943.12MB 943.14MB 140.00MB
datadog-agent-arm64-deb -0.02MB 933.88MB 933.90MB 140.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51707739 --os-family=ubuntu

Note: This applies to commit 53ff257

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7cb92b7d-c293-4956-8265-7d706a8e8b35

Baseline: 7f64411
Comparison: 53ff257
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization +0.64 [+0.60, +0.67] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.15 [+0.08, +0.22] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.13 [-0.33, +0.60] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.13 [-0.64, +0.90] 1 Logs
quality_gate_logs % cpu utilization +0.09 [-3.13, +3.30] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.06 [-0.63, +0.74] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.04 [-0.79, +0.87] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.87, +0.94] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.88, +0.92] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.09, +0.12] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.64, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.74, +0.65] 1 Logs
file_tree memory utilization -0.24 [-0.37, -0.11] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.34 [-1.12, +0.43] 1 Logs
quality_gate_idle_all_features memory utilization -0.36 [-0.44, -0.27] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput -0.37 [-1.07, +0.32] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_500ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant