Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick 2529b667 notReady nodes in scaledown #26

Open
wants to merge 4 commits into
base: datadog-master-3.0
Choose a base branch
from

Conversation

dbenque
Copy link

@dbenque dbenque commented Jan 25, 2021

No description provided.

JulienBalestra and others added 4 commits January 7, 2021 10:35
…resource

And remove local-data volumes from pods before scheduler evaluations:
VolumeBinding predicate does not support no-provisioner storage classes.

Signed-off-by: Julien Balestra <[email protected]>
With 1.5k MIGs attached to a cluster, cluster-autoscaler needs about
40mn to start. Refreshing MIGs+IT concurrently brings that down to
about 5mn.

Upstream PR kubernetes#3704 (under review).
On our k8s v1.10 (configured without TaintBasedEvictions feature gate),
recent CA versions fails to consider dead nodes (unkown status) as
unschedulable. Likely Reason is newer CA versions relies on the
/unreachable taint (provided by TaintBasedEvictions) for the node to
be considered unschedulable.

Our best, middle term fix will be to enable TaintBasedEvictions feature
gate on 1.10 clusters. This will require a sufficient testing period, so
until then, this (hopefuly) temporary patch should cover the case.
@dbenque dbenque requested review from bpineau and a team January 25, 2021 19:53
Copy link
Member

@bpineau bpineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bpineau bpineau force-pushed the datadog-master-3.0 branch from 6097518 to 8d1473a Compare February 1, 2021 11:29
@bpineau bpineau force-pushed the datadog-master-3.0 branch from 46a4410 to 68c4689 Compare March 3, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants