[CTM-19] Move disk resize before starting the server

[lucymcnatt]

Jira ticket: https://broadworkbench.atlassian.net/browse/CTM-19

Summary of changes

What

• Moves the resize command to update the filesystem allocation to before the jupyter/rstudio servers are started in the gce-init scipt

Why

• If the servers are started before the resize happens upon runtime creation, they fail when the disk is full
• In this error case, users are stuck and can't recover their disk without manual intervention

Testing these changes

What to test

• Create a runtime
• Fill the disk
• Try to pause, see that it never starts up
• Recreate runtime with full disk, see that it errors
• Delete errored runtime
• Recreate, but increase disk size
• Creation should succeed

Who tested and where

• This change is covered by automated tests
  • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
• I validated this change
• Primary reviewer validated this change
• I validated this change in the dev environment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.15%. Comparing base (0903403) to head (1221f3f).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4896   +/-   ##
========================================
  Coverage    74.15%   74.15%           
========================================
  Files          131      131           
  Lines        11089    11089           
  Branches       880      880           
========================================
  Hits          8223     8223           
  Misses        2866     2866           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0903403...1221f3f. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[LizBaldo]

That makes a lot of sense, thanks for thinking through this tricky init script. Should the same change be made for the dataproc init script?

[lucymcnatt]

Should the same change be made for the dataproc init script?

So I checked and the init-actions script doesn't do anything with disks, so I think its fine to leave as is?

[LizBaldo]

Gotcha, thanks for checking!