Skip to content

Conversation

@lucymcnatt
Copy link
Collaborator

@lucymcnatt lucymcnatt commented Jan 20, 2026

Jira ticket: https://broadworkbench.atlassian.net/browse/CTM-322

Summary of changes

What

  • This updates the current pubsub message subscriber to process a new type of message that google emits when cryptomining is detected on a VM
  • It decodes this message and sends a deleteRuntimeMessage

Why

  • Our current detection system is outdated and has been failing to detect cryptomining. This depends on google's detection system rather than our own to stay in compliance with their and out TOS

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@lucymcnatt lucymcnatt requested a review from a team as a code owner January 20, 2026 16:11
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 89.28571% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.15%. Comparing base (474d497) to head (2b2f381).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...nch/leonardo/monitor/NonLeoMessageSubscriber.scala 89.28% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4895      +/-   ##
===========================================
+ Coverage    74.12%   74.15%   +0.03%     
===========================================
  Files          131      131              
  Lines        11064    11089      +25     
  Branches       882      880       -2     
===========================================
+ Hits          8201     8223      +22     
- Misses        2863     2866       +3     
Files with missing lines Coverage Δ
...nch/leonardo/monitor/NonLeoMessageSubscriber.scala 70.46% <89.28%> (+3.53%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 474d497...2b2f381. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@aednichols aednichols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant! I appreciate the "looks like" style comments.

@lucymcnatt lucymcnatt merged commit 0903403 into develop Jan 20, 2026
21 of 22 checks passed
@lucymcnatt lucymcnatt deleted the CTM-322-crypto branch January 20, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants