Skip to content

Conversation

@dvoet
Copy link
Contributor

@dvoet dvoet commented Dec 9, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/CORE-210

a new action was added in sam and unfortunately that is a breaking change for Leo even though it should not care

Summary of changes

What

Why

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.77%. Comparing base (4bfd563) to head (298712a).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...dinstitute/dsde/workbench/leonardo/samModels.scala 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4808      +/-   ##
===========================================
- Coverage    74.79%   74.77%   -0.02%     
===========================================
  Files          165      165              
  Lines        14951    14954       +3     
  Branches      1187     1187              
===========================================
  Hits         11182    11182              
- Misses        3769     3772       +3     
Files with missing lines Coverage Δ
...dinstitute/dsde/workbench/leonardo/samModels.scala 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfd563...298712a. Read the comment docs.

@dvoet dvoet changed the title add can_access action CORE-210 add can_access action Dec 9, 2024
@dvoet dvoet requested a review from LizBaldo December 9, 2024 19:25
@dvoet dvoet requested a review from marctalbott December 9, 2024 20:27
Copy link
Collaborator

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleh, good catch, this is annoying, but hopefully we won't need to do that once we use the Sam client? 🤞

@dvoet dvoet merged commit 42e499f into develop Dec 10, 2024
22 of 23 checks passed
@dvoet dvoet deleted the extra_actions branch December 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants