Skip to content

Conversation

@LizBaldo
Copy link
Collaborator

@LizBaldo LizBaldo commented Dec 4, 2024

Jira ticket: https://broadworkbench.atlassian.net/browse/AN-257

Summary of changes

What

  • Follow up PR to [AN-257] Update mysql version to 5.7 #4804
  • This mainly handles the liquibase change necessary for Mysql 8.4 compatibility. The VERY annoying thing is MySQL decision to not support partial keys as FK references anymore, hence us setting the restrict_fk_on_non_standard_key to OFF because what we are doing has a very sensible business use case, and a lot of people are pushing back against MySQL decision to not support it, so we will see where this goes next.

Why

  • BEEs cannot update from 5.6 to 8.4 directly so after bumping to 5.7 we need to do it again, fun!

Testing these changes

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.77%. Comparing base (efdd655) to head (09695f8).
⚠️ Report is 57 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4806      +/-   ##
===========================================
- Coverage    74.79%   74.77%   -0.02%     
===========================================
  Files          165      165              
  Lines        14951    14954       +3     
  Branches      1187     1187              
===========================================
  Hits         11182    11182              
- Misses        3769     3772       +3     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdd655...09695f8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LizBaldo LizBaldo marked this pull request as ready for review December 5, 2024 15:06
@LizBaldo LizBaldo requested a review from lucymcnatt December 5, 2024 15:06
<changeSet logicalFilePath="leonardo" author="thibault" id="label">
<validCheckSum>8:1d8581dc0977ea88b1f006f6bc00f5b9</validCheckSum>
<comment>
Mysql 8.4+ does not allow partial keys to be referenced for a foreign key anymore, see https://bugs.mysql.com/bug.php?id=114838.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the helpful comment here!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An afternoon of frantic googling that I will never get back 😭

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😿

@LizBaldo LizBaldo requested a review from a team as a code owner December 11, 2024 18:30
@LizBaldo LizBaldo closed this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants