Skip to content

Conversation

@eweitz
Copy link
Member

@eweitz eweitz commented Jan 9, 2026

Addresses

https://broadworkbench.atlassian.net/browse/DT-2777

Summary

Per DUOS-2753, we only only want to show Study and Datasets in Library after DAC approval (unless user is signing official and viewing their own institution). That gets passed in a “visibility modifier”.

However, we only (sort of) do that in the initial /index search request on the Data Library. When e.g. the user selects a filter then deselects it to the default unfiltered state, the visibility modifier is not applied.

The visibility modifier should always be passed (unless user is signing official and viewing their own institution).

To reproduce:

  1. Open Network Panel in Chrome DevTools
  2. Load Data Library: https://duos-k8s.dsde-dev.broadinstitute.org/datalibrary
  3. In Network Panel, filter to XHR/fetch and “index”
  4. Expand post body and note {term: {dacApproval: true}} is included
  5. Click a filter to select it
  6. Click it again to deselect it
  7. Expand post body of most recent /index request and note {term: {dacApproval: true}} is not included. Per DUOS-2753, it should be.

Before

See video. It might have no obvious impact on dev with my depicted user status, but this demonstrates the lurking issue via the discrepant post bodies as described in steps 4 and 7 above.

Visibility_filter_not_applied_upon_clearing_filters__DUOS_UI__2026-01-09.mov

After

Now the Data Library visibility filter is applied even after clearing filters.

Visibility_filter_applied_upon_clearing_filters__DUOS_UI__2026-01-09.mov

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Base automatically changed from ew-dt-2435-nonredundant-index-requests to develop January 14, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants