Skip to content

DT-2791, DT-2792: Allow SOs to create elections #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rushtong wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

DT-2791, DT-2792: Allow SOs to create elections #2776

rushtong wants to merge 17 commits into from
+257 −19

Conversation

@rushtong
Copy link
Contributor

@rushtong rushtong commented Jan 14, 2026 •
edited
Loading

Addresses

https://broadworkbench.atlassian.net/browse/DT-2791
https://broadworkbench.atlassian.net/browse/DT-2792

Summary

Allow SOs to create elections for a restricted set of datasets

  • Requires the dataset's DAC to have a specific rule enabled
  • Requires the SO be listed on the DAR

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@rushtong rushtong marked this pull request as ready for review January 14, 2026 19:34
@rushtong rushtong requested a review from a team as a code owner January 14, 2026 19:34
@rushtong rushtong requested review from eweitz and fboulnois and removed request for a team January 14, 2026 19:34
otchet-broad
otchet-broad reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@otchet-broad otchet-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize my new question might be better suited for our product owner. I'll put a parking lot agenda item out for tomorrow.

@rushtong rushtong marked this pull request as draft January 15, 2026 18:58
@rushtong
Merge branch 'refs/heads/develop' into gr-so-elections
cbc354a 
# Conflicts:
#	src/main/java/org/broadinstitute/consent/http/resources/DarCollectionResource.java
#	src/main/java/org/broadinstitute/consent/http/service/dao/DarCollectionServiceDAO.java
#	src/test/java/org/broadinstitute/consent/http/service/dao/DarCollectionServiceDAOTest.java
@rushtong
feat: update actionable dataset logic
28692f5
@rushtong
feat: tests
76c0d39
@rushtong rushtong marked this pull request as ready for review January 15, 2026 21:09
@rushtong rushtong requested a review from eweitz January 15, 2026 21:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 15, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@otchet-broad otchet-broad otchet-broad approved these changes

@fboulnois fboulnois Awaiting requested review from fboulnois fboulnois is a code owner automatically assigned from DataBiosphere/dsp-data-team-eng

@eweitz eweitz Awaiting requested review from eweitz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rushtong @eweitz @otchet-broad