-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
major adjustment to makunov2 and other minor adjustment. #37
Merged
MikuAuahDark
merged 37 commits into
DarkEnergyProcessor:over_the_rainbow
from
MKN-Makuno:over_the_rainbow_Xp
May 7, 2024
Merged
major adjustment to makunov2 and other minor adjustment. #37
MikuAuahDark
merged 37 commits into
DarkEnergyProcessor:over_the_rainbow
from
MKN-Makuno:over_the_rainbow_Xp
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since autoplay can not use this button so I change to just don't show it.
I have no idea when this crash occurred. But when watching the replay for the second time, and so on. It uses beatmapDisplayName instead. I changed it to self.persist.beatmapName and this problem is gone. So I have no idea right now if this is fixed or not.
I have no idea what I adjust for this
This reverts commit 40998b3.
This seem to be good spot for now.
- Use sy_useoverflow = 2 as default - Add Combo burst effect - Judgement & Combo text now scalable via LS2 setting - Reduce Live Clear screen time from 5 to 3 seconds - Remove Text in Live Clear screen (for re-design soon) - Adjust Stamina & Overflow number text got cut-off
- Optimizing drawStatus function - Reworking live clear animation - Adjusted the combo/judgement text size calculation - Adjusted live clear animation duration to 4 seconds - Fixing combo burst effect unusual play/reset
Except fourth one because I did not remember it.
one of the problem that nearly end up destroying my keyboard
I forgot about this
- reduce result transition time (4s → 2s) - adjust combo & judgement text position when Sudden used
This reverts commit 2f025b9.
MikuAuahDark
merged commit May 7, 2024
e27795b
into
DarkEnergyProcessor:over_the_rainbow
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.