-
-
Notifications
You must be signed in to change notification settings - Fork 3
컴포넌트 접근성 개선(aria-invalid, aria-required) #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hyoseong1994
wants to merge
2
commits into
main
Choose a base branch
from
645-aria-invalid-and-required
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+157
−68
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -434,7 +434,16 @@ describe("상태 관리", () => { | |
| }); | ||
|
|
||
| describe("접근성 및 기타", () => { | ||
| test("invalid가 true일 때 오류 메시지가 표시된다", () => { | ||
| test("invalid prop이 없을 때 aria-invalid 속성이 올바르게 설정된다", () => { | ||
| render( | ||
| <Select placeholder="라이브러리를 선택하세요"> | ||
| <option value="react">React</option> | ||
| </Select>, | ||
| ); | ||
| expect(screen.getByRole("combobox")).not.toHaveAttribute("aria-invalid"); | ||
| }); | ||
|
|
||
| test("invalid가 true일 때 aria-invalid 속성이 올바르게 설정된다", () => { | ||
| render( | ||
| <Select invalid placeholder="라이브러리를 선택하세요"> | ||
| <option value="react">React</option> | ||
|
|
@@ -446,7 +455,7 @@ describe("접근성 및 기타", () => { | |
| ); | ||
| }); | ||
|
|
||
| test("invalid가 false일 때 오류 메시지가 표시되지 않는다", () => { | ||
| test("invalid가 false일 때 aria-invalid 속성이 올바르게 설정된다", () => { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 테스트 기준도 더 명확해져서 좋군요👍 |
||
| render( | ||
| <Select invalid={false} placeholder="라이브러리를 선택하세요"> | ||
| <option value="react">React</option> | ||
|
|
@@ -455,6 +464,15 @@ describe("접근성 및 기타", () => { | |
| expect(screen.getByRole("combobox")).not.toHaveAttribute("aria-invalid"); | ||
| }); | ||
|
|
||
| test("required prop이 없을 때 aria-required 속성이 올바르게 설정된다", () => { | ||
| render( | ||
| <Select placeholder="라이브러리를 선택하세요"> | ||
| <option value="react">React</option> | ||
| </Select>, | ||
| ); | ||
| expect(screen.getByRole("combobox")).not.toHaveAttribute("aria-required"); | ||
| }); | ||
|
|
||
| test("required가 true일 때 aria-required 속성이 올바르게 설정된다", () => { | ||
| render( | ||
| <Select required placeholder="라이브러리를 선택하세요"> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나이스 캐치!