Skip to content

CheckboxGroup 컴포넌트 구현 #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yolophg wants to merge 3 commits into
base: main
Choose a base branch
from
Open

CheckboxGroup 컴포넌트 구현 #711

yolophg wants to merge 3 commits into from
+792 −0

Conversation

@yolophg
Copy link
Contributor

@yolophg yolophg commented Jan 3, 2026 •
edited
Loading

변경 사항

  • CheckboxGroup 컴포넌트 구현
  • 개별 Checkbox를 그룹 단위로 제어할 수 있도록 구조 정리 및 상태 관리 로직 구성

목적

  • 컴포넌트 단위의 일관성을 위해

리뷰어에게

  • API 네이밍이나 그룹 구조가 직관적인지 등 사용 흐름이 명확하게 드러나는지 확인 부탁드립니다.

PR 작성자 체크 리스트

  • UI Review를 요청하고 검토를 받았나요?
  • UI Tests를 진행했나요?

@yolophg yolophg linked an issue Jan 3, 2026 that may be closed by this pull request
CheckboxGroup 컴포넌트 구현 #597
Open
@yolophg yolophg force-pushed the 597-implement-checkboxgroup branch 3 times, most recently from 4b0bd7e to 567a8f2 Compare January 3, 2026 00:37
@codecov
Copy link

codecov bot commented Jan 3, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/CheckboxGroup/CheckboxGroup.tsx 93.10% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@yolophg yolophg force-pushed the 597-implement-checkboxgroup branch from 567a8f2 to 43a7500 Compare January 3, 2026 00:42
@codecov
Copy link

codecov bot commented Jan 3, 2026 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 22.63kB (4.08%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
daleui-bundle-esm 577.65kB 22.63kB (4.08%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: daleui-bundle-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 22.13kB 276.28kB 8.71% ⚠️
assets/index-*.css 503 bytes 64.46kB 0.79%

@yolophg yolophg marked this pull request as ready for review January 9, 2026 23:49
@yolophg yolophg requested a review from a team as a code owner January 9, 2026 23:49
@Hecklebot Hecklebot mentioned this pull request Jan 10, 2026
Closed
hyoseong1994
hyoseong1994 reviewed Jan 13, 2026
View reviewed changes
src/components/CheckboxGroup/CheckboxGroup.stories.tsx Outdated
Comment on lines 46 to 48
<div
className={css({ display: "flex", flexDirection: "column", gap: "32" })}
>
Copy link
Contributor

@hyoseong1994 hyoseong1994 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중앙정렬이 들어가도 괜찮다면 VStack 컴포넌트를 사용하는것이 어떨까요?

Copy link
Contributor Author

@yolophg yolophg Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VStack으로 변경하여 반영했습니다. 감사합니다!

src/components/CheckboxGroup/CheckboxGroup.tsx
onValueChange: (value: string, checked: boolean) => void;
} | null>(null);

export interface CheckboxGroupProps {
Copy link
Contributor

@hyoseong1994 hyoseong1994 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required는 지원안하는건지 궁금합니다.

Copy link
Contributor Author

@yolophg yolophg Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디자이너와 명확히 확인 후 반영토록 하겠습니다, 감사합니다!

sounmind
sounmind reviewed Jan 15, 2026
View reviewed changes
src/components/CheckboxGroup/CheckboxGroup.tsx Outdated
Comment on lines 35 to 45
/**
* 컴포넌트가 처음 렌더링될 때 선택되는 값들입니다.
* @default undefined
*/
defaultValue?: string[];

/**
* 외부에서 선택 값을 직접 제어할 때 사용합니다.
* @default undefined
*/
value?: string[];
Copy link
Member

@sounmind sounmind Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string 배열인데 변수 이름은 단수라 어색하네요. 복수형으로 바꾸면 자연스러울 것 같은데 어떻게 생각하시나요?

Copy link
Contributor Author

@yolophg yolophg Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

복수형 좋습니다, defaultValues로 수정하였습니다. 감사합니다!

sounmind
sounmind reviewed Jan 15, 2026
View reviewed changes
src/components/CheckboxGroup/CheckboxGroup.tsx
* true이면 모든 체크박스가 비활성화되어 상호작용이 불가합니다.
* @default false
*/
disabled?: boolean;
Copy link
Member

@sounmind sounmind Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default가 false라면서 컴포넌트 함수 default parameter에는 아무것도 할당되어 있지 않은데 의도하신 건가요?

Copy link
Contributor Author

@yolophg yolophg Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc과 일치하도록 함수 파라미터에 기본값을 추가했습니다. 짚어주셔서 감사합니다!

sounmind
sounmind reviewed Jan 15, 2026
View reviewed changes
src/components/CheckboxGroup/CheckboxGroup.tsx
Comment on lines +184 to +188
/**
* true이면 이 체크박스가 비활성화됩니다.
* @default false
*/
disabled?: boolean;
Copy link
Member

@sounmind sounmind Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 이 코멘트와 동일합니다.

Copy link
Contributor Author

@yolophg yolophg Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마찬가지로 doc과 일치하도록 함수 파라미터에 기본값을 추가했습니다.

@yolophg yolophg force-pushed the 597-implement-checkboxgroup branch from af80521 to f0efba2 Compare January 16, 2026 22:39
@yolophg yolophg marked this pull request as draft January 16, 2026 22:40
@yolophg yolophg force-pushed the 597-implement-checkboxgroup branch from f0efba2 to e07630c Compare January 16, 2026 22:43
@yolophg yolophg marked this pull request as ready for review January 16, 2026 23:06
hyoseong1994
hyoseong1994 reviewed Jan 17, 2026
View reviewed changes
src/components/CheckboxGroup/CheckboxGroup.stories.tsx
Comment on lines +131 to +133
<CheckboxItem value="apple">사과</CheckboxItem>
<CheckboxItem value="banana">바나나</CheckboxItem>
<CheckboxItem value="orange">오렌지</CheckboxItem>
Copy link
Contributor

@hyoseong1994 hyoseong1994 Jan 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

동일한 피드백입니다.

#711 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sounmind sounmind sounmind left review comments

@hyoseong1994 hyoseong1994 hyoseong1994 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@yolophg yolophg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CheckboxGroup 컴포넌트 구현

4 participants

@yolophg @sounmind @hyoseong1994