Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LintのCI追加 #4

Merged
merged 3 commits into from
Nov 23, 2024
Merged

LintのCI追加 #4

merged 3 commits into from
Nov 23, 2024

Conversation

takatea
Copy link
Contributor

@takatea takatea commented Nov 22, 2024

what

lintのCIだけ追加した!

確認事項

  • CIがPassするか

一旦書くことはやったこと + なにを確認したか
とかの2つくらいかな?
目的とかはIssueに基本書くとかかなぁ。おいおいだな。

@takatea takatea requested a review from RYoJiy November 22, 2024 17:30
@takatea takatea self-assigned this Nov 22, 2024
Copy link
Contributor

@RYoJiy RYoJiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't implemented dependency caching yet, because early testing showed bun install was faster than using Github's caching mechanism.

cacheいらんのやって思って調べたら、bunが早すぎるらしいなw
LGTMです
image

@@ -6,9 +6,10 @@
"scripts": {
"dev": "vite",
"build": "tsc -b && vite build",
"lint": "biome lint --apply ./src",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、古いoption使ってしまってた。修正あざま。

@takatea
Copy link
Contributor Author

takatea commented Nov 23, 2024

cacheいらんのやって思って調べたら、bunが早すぎるらしいなw

せやねん、キャッシュの仕組み無理やりつけることできるけどキャッシュ使うよりbun install普通にやる方が早いらしいw

@takatea takatea merged commit c2269f4 into main Nov 23, 2024
1 check passed
@takatea takatea deleted the add-ci-for-lint branch November 23, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants