Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reshade configuration #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sporif
Copy link

@Sporif Sporif commented May 18, 2020

This is an attempt to simplify ReShade configuration while maintaining backwards compatibility. It allows you to specify the shader filename in effects and the path to the reshade-shaders folder in reshadePath (the folder must contain "Shaders" and "Textures" dirs), e.g

effects = Monochrome.fx
reshadePath = /usr/share/reshade

You can specify the shaders with the .fx extension or not. If there's a name conflict in the future the vkBasalt effect will take priority so using .fx is probably better, and it's clearer that it's a ReShade shader.

reshadeIncludePath and reshadeTexturePath are higher priority than reshadePath. I also added reshadeShaderPath for specifying the Shaders dir because its name is more intuitive.

You can still specify the shader with a path i.e

effects = monochrome.fx
monochrome = /usr/share/reshade/Shaders/Monochrome.fx

But If it's a relative path it's added to the shader path.

And finally the settings for ReShade shaders are now specified with the shader name as prefixes (so they don't clash + better readability). e.g

effects = Technicolor
Technicolor_Strength = 1

@DadSchoorse
Copy link
Owner

I'm not sure that's the right thing to do, ideally vkBasalt should support multiple different reshade shader repos at the same time.

@pchome
Copy link
Contributor

pchome commented Jan 1, 2021

What about support multiple different reshade shader repos by their repo_id?

If specified, just look into ${shared}/${repo_id}/Shaders. If not, ${shared}/crosire/reshade-shaders/Shaders.

https://www.pcgamingwiki.com/wiki/ReShade#List_of_known_shader_repositories

0001-Hack-support-multiple-reshade-repos.patch.gz (draft)

Then I installed multiple different reshade shader repos into /usr/share/reshade and used them in this random mix example config:

depthCapture = on

effects = effect1:effect5:effect7:cas:effect8

effect1 = LUT.fx
#effect1_repo_id = crosire/reshade-shaders

effect5 = FXAA.fx
effect5_repo_id = CeeJayDK/SweetFX

effect7 = Comic.fx
effect7_repo_id = Daodan317081/reshade-shaders

effect8 = ColorIsolation.fx
effect8_repo_id = Daodan317081/reshade-shaders

vkBasalt-multiple-reshade-repos

or maybe something like this would be better, or maybe both variants

...
effect1 = LUT.fx
effect5 = CeeJayDK/SweetFX:FXAA.fx
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants