Jierans/daq triggeralgs v10 #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de to David's code
…trigger into jierans/daq_triggeralgs_v10
|
I pushed changes to develop that update to LArSoft v10. I had to make a number of other changes to develop too, in order to get the build to work with cetmodules, and remove all the find_ups_product()s. Marking this as a draft -- it may no longer be needed, but we do need to look at the daq_triggeralgs branch and bring that code into the offline management. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-instantiation of dunetrigger PR 16 from Wes's repo. This is the comment from James:
Larsoft v10 replaces the geometry service with the WireReadout class to perform channel mapping. This requires changes to module code. However this merging this will break larsoft v9.xx installs. Some unnecessary instantiations of the geom service also needs to be removed as it causes unused-variable warnings when compile (and since larsoft by default builds with -WError).
Since we are targeting v10 for eventual publishing with other dunesw repos, this should be merged when convenient.