Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mroda/daphne v5 #31

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Mroda/daphne v5 #31

merged 2 commits into from
Jan 9, 2025

Conversation

wesketchum
Copy link
Contributor

merge production v4 to develop

@mroda88 mroda88 changed the base branch from develop to patch/fddaq-v5.2.1 January 6, 2025 12:59
wesketchum
wesketchum commented Jan 6, 2025
View reviewed changes
Copy link
Contributor Author

@wesketchum wesketchum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marco added the try/catch on the LED configuration and sending to ERS, which I approve. (I can't officially approve my own PR...)

mroda88
mroda88 approved these changes Jan 9, 2025
View reviewed changes
Copy link

@mroda88 mroda88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some ERS layer to make the errors more understandable from the user point of view

@mroda88 mroda88 merged commit f47992b into patch/fddaq-v5.2.1 Jan 9, 2025
@mroda88 mroda88 deleted the mroda/daphne_v5 branch January 9, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroda88 mroda88 mroda88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesketchum @mroda88