Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched to using subdetector_to_string and subsystem_to_string methods #43

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

bieryAtFnal
Copy link
Collaborator

…in hdf5_dump.py

I made use of Python integer-to-SourceID::Subsystem and integer-to-DetID::Subdetector conversion functions in recent changes to wib2decoder.py, and it seemed like the use of them in hdf5_dump.py would be useful. This PR has candidate changes in this regard.

Of course, if there were reasons for not using those conversion functions, we can skip this PR.

@bieryAtFnal bieryAtFnal requested a review from dingp October 20, 2022 18:11
@dingp
Copy link
Contributor

dingp commented Oct 21, 2022

Is it worth to keep the current DETECTOR and SUBSYSTEM dictionary and only use them if daqdataformats and detdataformats python modules were not found? This maintains the ability to run the script outside of the DAQ development environment. Though I guess few people actually does this.

One of the concept when firstly designing hdf5_dump.py was it remains as an independent/external tool which only relies on "built-in" python modules. We can have a separate python module/script which leverages other package's python bindings/modules to decode the HDF5 data file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants