Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataStoreConf now references a StorageDevice resource #378

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

eflumerf
Copy link
Member

@eflumerf eflumerf commented Aug 30, 2024

Test new functionality in HDF5Write_test.

a disk usage quota. Test new functionality in HDF5Write_test.
@eflumerf
Copy link
Member Author

Ensemble with
#378
DUNE-DAQ/confmodel#40
DUNE-DAQ/appmodel#115

@eflumerf eflumerf requested a review from wesketchum August 30, 2024 16:47
@wesketchum
Copy link
Contributor

I'm not sure about the quota thing ... do I have it right that this means a quota is set at configuration, and then a data writer can write up to that amount but after that it will give warnings that there isn't more space available?

  • How does assigning that quota work? Does it actually look up the space on disk or just purely configuration? Is the configuration going to dynamically determine it's quota?
  • For long-going runs, it could be a data writer writes lots of data, but because of the file management they are transferred and then deleted, and so there's no issue with space. We don't want to lock ourselves out of writing more data from a data writer if there's not actually a problem with writing more data, do we? But maybe I don't understand it.

@eflumerf
Copy link
Member Author

These are great points, and the quota was only implemented because it was implied by the configuration. However, in talking with Gordon, I realized that this was never actually a requested feature, so I'm backing it out.

@eflumerf eflumerf changed the title DataStoreConf now references a StorageDevice resource, which can impose DataStoreConf now references a StorageDevice resource Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants