Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slidepane): add two types and close ways #505

Merged
merged 2 commits into from
Oct 31, 2024
Merged

fix(slidepane): add two types and close ways #505

merged 2 commits into from
Oct 31, 2024

Conversation

LuckyFBB
Copy link
Collaborator

@LuckyFBB LuckyFBB commented Oct 14, 2024 •
edited
Loading

变更类型

请选择以下选项以描述 PR 的类型：

  • Bug 修复（修复现有问题）
  • 新功能（添加了一个功能）
  • 代码优化（性能改进、代码重构）
  • 文档更新
  • 单测新增或修改
  • 其他（请说明）：

相关问题

#494

变更内容

  • 删除 visible 使用 open
  • 增加 type prop，form | normal，两者的 mask 不同
    • form 下不可自定义 mask/maskClosable，默认开启 mask，关闭 maskClosable；增加右上角的关闭 icon
    • normal 下可以配置 mask/maskClosable，默认不开启 mask

详细描述

对应 Previewer

@LuckyFBB LuckyFBB requested review from liuxy0551, mortalYoung and jin-sir and removed request for liuxy0551 and mortalYoung October 25, 2024 03:50
mortalYoung
mortalYoung reviewed Oct 25, 2024
View reviewed changes
src/slidePane/index.md Outdated Show resolved Hide resolved
mortalYoung
mortalYoung approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jin-sir jin-sir merged commit 2c82605 into DTStack:master Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jin-sir jin-sir jin-sir approved these changes

@mortalYoung mortalYoung mortalYoung approved these changes

@liuxy0551 liuxy0551 Awaiting requested review from liuxy0551

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuckyFBB @mortalYoung @jin-sir