feat :: move 값 repuest에서 받아오게 변경

[ByunDohwi]

Summary by CodeRabbit

릴리스 노트

• Refactor
  • 교실 이동 요청의 move 필드를 이제 필수로 지정합니다. 모든 요청에서 이 값을 반드시 제공해야 합니다.
  • 요일 기반의 자동 조정 로직을 제거하여, 사용자가 명시한 move 값이 그대로 적용됩니다.
• Style
  • 코드 내 불필요한 공백 및 임포트 정리로 가독성 개선.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

교실 이동 관련 DTO의 move 필드가 nullable에서 non-null로 변경되었고, 서비스 레이어에서 요일 기반 분기 로직이 제거되어 요청의 move 값을 그대로 사용하도록 단순화되었습니다.

Changes

Cohort / File(s)	변경 요약
DTO 필드 타입 변경 src/main/kotlin/dsm/pick2024/domain/classroom/presentation/dto/request/UserMoveClassroomRequest.kt	move 필드를 String? → String으로 변경하여 필수 입력으로 전환
서비스 로직 단순화 src/main/kotlin/dsm/pick2024/domain/classroom/service/MoveClassroomApplicationService.kt	요일 기반 move 계산 및 관련 예외/임포트(DayOfWeek, LocalDate, MoveRequiredOnClubDayException) 제거; 저장 시 항상 request.move 사용. 기존 검증(중복 이동/신청 존재) 유지
무의미한 공백 정리 src/main/kotlin/dsm/pick2024/domain/application/service/ChangeApplicationStatusService.kt	불필요한 빈 줄 2개 제거(로직 변화 없음)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20분

Poem

🐰
move는 이제 반드시 오라지요,
옛 요일 굴레는 깔끔히 벗어났네.
코드는 가벼워지고 발걸음은 빠르게,
당근 한 입에 축하를 나누어요 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PR 제목이 변경사항의 주요 내용과 관련이 있습니다. move 필드를 request에서 받도록 변경한 것이 주요 변경사항이며, 제목이 이를 명확히 설명합니다.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 92ab015 and d7a398a.

📒 Files selected for processing (1)

• src/main/kotlin/dsm/pick2024/domain/application/service/ChangeApplicationStatusService.kt

💤 Files with no reviewable changes (1)

• src/main/kotlin/dsm/pick2024/domain/application/service/ChangeApplicationStatusService.kt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Check Code Quality

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Fix all issues with AI Agents

In
@src/main/kotlin/dsm/pick2024/domain/classroom/presentation/dto/request/UserMoveClassroomRequest.kt:
- Line 4: Add validation to the UserMoveClassroomRequest.move property by
annotating it with @field:NotBlank and @field:Size(max = 20) to prevent empty
strings and enforce the DB varchar(20) limit, and update the
ClassroomController.moveClassroom handler to validate incoming payloads by
adding @Valid to the @RequestBody parameter (i.e., change the signature to
accept @Valid @RequestBody userMoveClassroomRequest).

In
@src/main/kotlin/dsm/pick2024/domain/classroom/service/MoveClassroomApplicationService.kt:
- Line 36: Add server-side validation for the incoming move value: annotate the
DTO field (UserMoveClassroomRequest.move) with appropriate validation
annotations (e.g., @NotNull or a custom @Pattern/@Enum validator), mark the
controller parameter with @Valid on the @RequestBody so Spring triggers
validation, and also add explicit service-side checks in
MoveClassroomApplicationService (validate request.move before using it) that
throw MoveRequiredOnClubDayException when move is missing/invalid; ensure the
controller returns validation errors consistently (e.g., via BindingResult or a
global @ExceptionHandler) so invalid client payloads are rejected.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 1ae4c38 and 92ab015.

📒 Files selected for processing (2)

• src/main/kotlin/dsm/pick2024/domain/classroom/presentation/dto/request/UserMoveClassroomRequest.kt
• src/main/kotlin/dsm/pick2024/domain/classroom/service/MoveClassroomApplicationService.kt