-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to uv #494
Migrate to uv #494
Conversation
a6c8c4a
to
d5109af
Compare
fb09bd5
to
b6d698f
Compare
ba41a65
to
2e754e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am very surprised how fast the environment setup with uv is. The installation of 77 packages in 49ms is insanely fast. The docs are almost build instantly.
Can you explain why you modified the library structure by moving capellambse into a src
folder? Is this necessary for uv to work? Or is this just best practice in order to exclude docs and tests from the build package?
I think you need to also check:
- CODEOWNERS (the paths aren't valid anymore)
py-capellambse/src/capellambse/repl.py
Line 25 in 2e754e3
./capellambse/repl.py test-5.0
This doesn't work anymore, first the path needs to include ./src but also withuv run
the tests aren't included anymore, so the test model can't be found.
The rest looks fine and as soon as this is merged I'll start to migrate to uv in other projects.
This helps maintain a clear distinction between what goes into the wheel and what doesn't.
Use uv for management of development dependencies and building in CI. This also migrates the "docs" and "test" extras to dependency groups, as they were only used to facilitate the dev setup, and did not actually add any functionality.
It's not strictly required for uv (in fact, uv doesn't care either way, it's up to the build backend to deal with this), but IMO this is a good opportunity for it. The two main reasons are:
Good catch! Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Use uv for management of development dependencies and building in CI.
This also migrates the "docs" and "test" extras to dependency groups, as they were only used to facilitate the dev setup, and did not actually add any functionality.