Maintain dropin lists #305
Conversation
There is no user we are aware of who uses the TextualEditor dropin.
| TextualEditor: | ||
| github: 'https://github.com/eclipse/capella-textual-editor' | ||
| type: updateSite | ||
| eclipseRepository: 'jar:https://download.eclipse.org/capella/addons/textualeditor/updates/releases/0.11.0/TextualEditor-updateSite-0.11.0.202208161352.zip!/' | ||
| installIU: | ||
| - 'org.polarsys.capella.scenario.editor.feature.feature.group' |
There was a problem hiding this comment.
I've noticed that TextualEditor was dropped with the reason that we are not aware of any active users that use the dropin. Is there any additional reason for it? The dropins.yml should represent a full list of available dropins. The user can decide which dropins to install from the list. It does not represent the dropins which are actually installed in the images. See also: https://dsd-dbs.github.io/capella-dockerimages/capella/base/#install-dropins
The removal of the dropin from the list of supported dropins is a breaking change and would require a new major release.
| @@ -8,24 +8,35 @@ dropins: | |||
| eclipseRepository: 'https://download.eclipse.org/capella/addons/xhtmldocgen/updates/releases/6.1.0/' | |||
| installIU: | |||
| - 'org.polarsys.capella.docgen.package.feature.feature.group' | |||
| DarcViewpoint: | |||
There was a problem hiding this comment.
| DarcViewpoint: | |
| Darc: |
I'd drop the "Viewpoint" suffix to keep it consistent as we don't use the viewpoint suffix for other add-ons. In the documentation it also only refers to "Capella Darc add-on".
| @@ -8,24 +8,35 @@ dropins: | |||
| eclipseRepository: 'https://download.eclipse.org/capella/addons/xhtmldocgen/updates/releases/6.1.0/' | |||
| installIU: | |||
| - 'org.polarsys.capella.docgen.package.feature.feature.group' | |||
| DarcViewpoint: | |||
There was a problem hiding this comment.
Add the dropin to the list of supported add-ons: https://github.com/DSD-DBS/capella-dockerimages/blob/main/docs/docs/capella/base.md?plain=1#L100
ci: Sort keys in `dropins.yml` files automatically
|
Hey @jamilraichouni. Any updates about this PR? Do we still need it or can it be closed? |
This maintains the dropin definition lists we have for 6.x.
Capella 7.x has not been considered (some dropins not released, other higher priorities)
For the review, have a concentrated look at the installIU id, please.