fix: Fixed docx import with headers that are also lists #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… headers and subheaders, unit test included Signed-off-by: Maksym Lysak <[email protected]>
maxmnemonic
requested review from
vagenas,
cau-git,
PeterStaar-IBM and
dolfim-ibm
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
This was referenced Jan 30, 2025
ceberam
previously approved these changes
Jan 31, 2025
Co-authored-by: Cesar Berrospi Ramis <[email protected]> Signed-off-by: Maxim Lysak <[email protected]>
Co-authored-by: Cesar Berrospi Ramis <[email protected]> Signed-off-by: Maxim Lysak <[email protected]>
nice! approved those commits |
dolfim-ibm
approved these changes
Jan 31, 2025
cau-git
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now such headers are converted as appropriate headers and subheaders, unit test included
Issue resolved by this Pull Request:
Resolves #612
Resolves #795
Resolves #738
Checklist: