Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Azure AI Search + Azure OpenAI RAG recipe notebook #675

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

farzad528
Copy link
Contributor

Azure AI Search RAG Example Using Docling

This notebook demonstrates how to build a Retrieval Augmented Generation (RAG) system using Docling and Azure AI Search. The example showcases document parsing, chunking, vector search integration, and RAG query implementation.

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • [] Tests have been added, if necessary.

Copy link

mergify bot commented Jan 4, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@farzad528
Copy link
Contributor Author

farzad528 commented Jan 5, 2025

@vagenas @pablocastro can you review :)

docs/examples/rag_azuresearch.ipynb Outdated Show resolved Hide resolved
docs/examples/rag_azuresearch.ipynb Outdated Show resolved Hide resolved
docs/examples/rag_azuresearch.ipynb Outdated Show resolved Hide resolved
docs/examples/rag_azuresearch.ipynb Outdated Show resolved Hide resolved
docs/examples/rag_azuresearch.ipynb Outdated Show resolved Hide resolved
docs/examples/rag_azuresearch.ipynb Show resolved Hide resolved
@farzad528
Copy link
Contributor Author

farzad528 commented Jan 13, 2025

@vagenas plz merge when ready

@vagenas
Copy link
Contributor

vagenas commented Jan 13, 2025

@farzad528 thanks for this nice example! 🙌

In order to align and merge:

  1. [CI] DCO check fails, i.e. commits are missing sign-off. To add your sign-off:
    • In your local branch, run: git rebase HEAD~10 --signoff
    • Force push your changes to overwrite the branch: git push --force-with-lease origin main
  2. [CI] Code styling fails. To address, install & run the commit hooks locally & push the new changes.
  3. I have added some in-line comments to address individual points.

@farzad528
Copy link
Contributor Author

@vagenas uhhh...i did your rebase command and I think I messed something up as it changed a lot of different files. any advice?

@vagenas
Copy link
Contributor

vagenas commented Jan 22, 2025

@farzad528 I see, we 'll try to reshape the branch history into a clean commit (attributing authorship accordingly) & merge this week.

Co-authored-by: Farzad <[email protected]>
Signed-off-by: Panos Vagenas <[email protected]>
@vagenas vagenas merged commit 9020a93 into DS4SD:main Jan 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants