Skip to content

Update plainNXTestPacket to return pointer to dns.Msg #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ACEx86 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

Update plainNXTestPacket to return pointer to dns.Msg #3073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dnscrypt-proxy/serversInfo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -761,7 +761,7 @@ func fetchDNSCryptServerInfo(proxy *Proxy, name string, stamp stamps.ServerStamp
msg, _, _, err := DNSExchange(
proxy,
proxy.xTransport.mainProto,
&query,
query,
stamp.ServerAddrStr,
dnscryptRelay,
&name,
Expand Down Expand Up @@ -849,7 +849,7 @@ func dohNXTestPacket(msgID uint16) []byte {
return msg.Data
}

func plainNXTestPacket(msgID uint16) dns.Msg {
func plainNXTestPacket(msgID uint16) *dns.Msg {
qName := make([]byte, 16)
charset := "abcdefghijklmnopqrstuvwxyz"
for i := range qName {
Expand All @@ -858,7 +858,7 @@ func plainNXTestPacket(msgID uint16) dns.Msg {
msg := dns.NewMsg(string(qName)+".test.dnscrypt.", dns.TypeNS)
msg.ID = msgID
msg.RecursionDesired = true
return *msg
return msg
}

func fetchDoHServerInfo(proxy *Proxy, name string, stamp stamps.ServerStamp, isNew bool) (ServerInfo, error) {
Expand Down