Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ResetRequired for certificate retrieval #2870

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

steven-bellock
Copy link
Contributor

If a SET_CERTIFICATE request results in ResetRequired then subsequent GET_CERTIFICATE requests for that slot, and GET_DIGESTS, should result in ResetRequired.

Signed-off-by: Steven Bellock [email protected]

@steven-bellock
Copy link
Contributor Author

steven-bellock commented Oct 23, 2024

@rw8896 to review.

Note that this reset mask should be sticky between GET_VERSIONs, although I haven't tested that yet.

  1. SET_CERTIFICATE -> ResetRequired
  2. VCA
  3. GET_CERTIFICATE ->ResetRequired

@steven-bellock steven-bellock marked this pull request as ready for review October 23, 2024 22:19
If a SET_CERTIFICATE request results in ResetRequired then subsequent GET_CERTIFICATE requests for that slot, and GET_DIGESTS, should result in ResetRequired.

Signed-off-by: Steven Bellock <[email protected]>
Copy link
Contributor

@rw8896 rw8896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks good to me.

@jyao1
Copy link
Member

jyao1 commented Oct 28, 2024

Question:
Do we need to update device secret lib sample?
Do we need to update spdm-emu?

@steven-bellock
Copy link
Contributor Author

Do we need to update device secret lib sample?

Maybe once libspdm_write_certificate_to_nvm has the need_reset parameter.

Do we need to update spdm-emu?

I will check if this breaks spdm-emu.

@steven-bellock
Copy link
Contributor Author

I will check if this breaks spdm-emu.

It appears to work OK with this change.

@jyao1
Copy link
Member

jyao1 commented Oct 29, 2024

Do we need to update device secret lib sample?

Maybe once libspdm_write_certificate_to_nvm has the need_reset parameter.

Could you please add that?

@steven-bellock
Copy link
Contributor Author

Could you please add that?

That's a separate issue / pull request.

@jyao1 jyao1 merged commit 2e8b643 into DMTF:main Oct 29, 2024
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants