-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return ResetRequired
for certificate retrieval
#2870
Conversation
@rw8896 to review. Note that this reset mask should be sticky between
|
If a SET_CERTIFICATE request results in ResetRequired then subsequent GET_CERTIFICATE requests for that slot, and GET_DIGESTS, should result in ResetRequired. Signed-off-by: Steven Bellock <[email protected]>
b5bfb95
to
7ce6196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks good to me.
Question: |
Maybe once
I will check if this breaks |
It appears to work OK with this change. |
Could you please add that? |
That's a separate issue / pull request. |
If a
SET_CERTIFICATE
request results inResetRequired
then subsequentGET_CERTIFICATE
requests for that slot, andGET_DIGESTS
, should result inResetRequired
.Signed-off-by: Steven Bellock [email protected]