Add SPDM 1.3 new feature: Set key pair info #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wenxing-hou
force-pushed
the
set_key_pair
branch
3 times, most recently
from
5dc3975
to
74c855e
Compare
Wenxing-hou
force-pushed
the
set_key_pair
branch
2 times, most recently
from
5d68bf3
to
94893e1
Compare
steven-bellock
requested changes
Aug 20, 2024
Wenxing-hou
force-pushed
the
set_key_pair
branch
2 times, most recently
from
4627477
to
40febd1
Compare
Signed-off-by: Wenxing Hou <[email protected]>
Signed-off-by: Wenxing Hou <[email protected]>
Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
set_key_pair
branch
from
40febd1
to
9b3ff0a
Compare
steven-bellock
requested changes
Sep 1, 2024
It is integrator's responsibility to ensure GET_KEY_PAIR_INFO_CAP is set, if SET_KEY_PAIR_INFO_CAP is set. Signed-off-by: Jiewen Yao <[email protected]>
…RATION. Signed-off-by: Jiewen Yao <[email protected]>
steven-bellock
requested changes
Sep 3, 2024
|
@steven-bellock , could you please give all comment one time, instead of one by one? |
|
@jyao1 I am done with the review. |
Signed-off-by: Jiewen Yao <[email protected]>
Signed-off-by: Jiewen Yao <[email protected]>
Signed-off-by: Jiewen Yao <[email protected]>
steven-bellock
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Is @Xiaohanjlll going to write some unit tests? Or should I do that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is pure set_key_pair_info feature now.