Add support for SUBSCRIBE_EVENT_TYPES #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-bellock
force-pushed
the
subscribe_events
branch
3 times, most recently
from
5657dc4
to
a9a26fd
Compare
|
I will add support for the key exchange |
jyao1
reviewed
Aug 20, 2024
jyao1
reviewed
Aug 20, 2024
| response_size, response); | ||
| } | ||
| } else { | ||
| if (request_size < (sizeof(spdm_message_header_t) + sizeof(uint32_t))) { |
There was a problem hiding this comment.
sizeof(spdm_message_header_t) + sizeof(uint32_t) can be sizeof(spdm_subscribe_event_types_request_t)
steven-bellock
force-pushed
the
subscribe_events
branch
from
a9a26fd
to
a093f1e
Compare
steven-bellock
force-pushed
the
subscribe_events
branch
3 times, most recently
from
6f7967c
to
66057d0
Compare
steven-bellock
commented
Sep 10, 2024
Signed-off-by: Steven Bellock <[email protected]>
steven-bellock
force-pushed
the
subscribe_events
branch
from
66057d0
to
c661bc1
Compare
jyao1
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steven Bellock [email protected]