Skip to content

Update test case 2 (Capabilities) to support SPDM 1.3#146

Merged
jyao1 merged 1 commit intoDMTF:mainfrom
wmaroneAMD:validator-work
Feb 17, 2025
Merged

Update test case 2 (Capabilities) to support SPDM 1.3#146
jyao1 merged 1 commit intoDMTF:mainfrom
wmaroneAMD:validator-work

Conversation

@wmaroneAMD
Copy link
Contributor

This updates test case 2 to check for and confirm report of SPDM 1.3 in GET_CAPABILITIES. All tests are the same at this time, and the test body for 1.2 has been made common with checks to toggle support for 1.3.

This does not validate any new capabilities, such as the supported algorithms block, added in SPDM 1.3.

@wmaroneAMD
Copy link
Contributor Author

Other than the supported algorithms block, I'm not seeing anything immediately obvious that is new. Mostly just things that will trigger new checks in later tests.

@wmaroneAMD
Copy link
Contributor Author

Hmm also need to update the docs.

@wmaroneAMD
Copy link
Contributor Author

Since this results in 2.5 and 2.7 being basically identical, would it make more sense to change 2.5 to 1.2+ and have a specific test for anything only in 1.3?

This updates test case 2 to check for and confirm report
of SPDM 1.3 in GET_CAPABILITIES. All tests are the same
at this time, and the test body for 1.2 has been made common
with checks to toggle support for 1.3.

This does not validate any new capabilities, such as the supported
algorithms block, added in SPDM 1.3.

Signed-off-by: Will Marone <Will.Marone@amd.com>
@jyao1
Copy link
Member

jyao1 commented Jan 15, 2025

If they are identical, we can just use 1.2+.

@wmaroneAMD
Copy link
Contributor Author

Ok. I will unify the general case and create a specific test for the 1.3 feature.

@wmaroneAMD
Copy link
Contributor Author

wmaroneAMD commented Jan 23, 2025

@jyao1 I think it's good as-is. The core of the test is unified for Capabilities 1.2 and up, which gets most of the reuse I think is possible. Unless there's a greater issue, I think a merge now is fine.

@wmaroneAMD
Copy link
Contributor Author

No changes, just removing a push to the wrong branch.

@jyao1 jyao1 merged commit 31838b2 into DMTF:main Feb 17, 2025
10 checks passed
@steven-bellock
Copy link
Contributor

Note that DMTF/libspdm#2968 adds support for SupportedAlgorithms. We can merge this pull request, but after libspdm is updated we can include SupportedAlgorithms as a new test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants