Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: add rust generator test #1154

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Dec 27, 2023

This would have caught a failure on #1148.

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1806ba4) 82.71% compared to head (a97e9d7) 82.77%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1154      +/-   ##
==========================================
+ Coverage   82.71%   82.77%   +0.05%     
==========================================
  Files         141      141              
  Lines        5310     5311       +1     
==========================================
+ Hits         4392     4396       +4     
+ Misses        918      915       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM, thanks!

testsuite/rust_generator/tests/AC/test.yml Outdated Show resolved Hide resolved
This would have caught a failure on DMOJ#1148.
@Riolku
Copy link
Contributor Author

Riolku commented Dec 27, 2023

Also, I did in fact test this against #1148.

Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kiritofeng kiritofeng merged commit cc641b3 into DMOJ:master Dec 27, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants