Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with latest versions of libxml2 #225

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Apr 20, 2024

There are some missing includes in tixi source code: tixi is using direct calls to malloc, free, ..., it shall include stdlib in its source code and not rely on 3rd party headers for that.

xmlStructuredErrorHandler shall use a const pointer to the error.

@joergbrech
Copy link
Contributor

Thanks for the PR 💐 I am a bit busy, so please excuse me if I keep you waiting. I will check it out as soon as I can.

Copy link
Contributor

@joergbrech joergbrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you so much! Also, thanks for updating our outdated CI workflow.

@joergbrech joergbrech merged commit 632df57 into DLR-SC:master May 6, 2024
17 checks passed
@mayeut mayeut deleted the conan branch May 6, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants