Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source comment typos #321

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix source comment typos #321

wants to merge 1 commit into from

Conversation

luzpaz
Copy link

@luzpaz luzpaz commented Sep 4, 2021

Found via codespell -q 3 -S ./dgl/src/pugl-upstream

@falkTX
Copy link
Contributor

falkTX commented Sep 7, 2021

Some of these should be pushed to their respective upstream.
Since this is purely cosmetic I will keep the PR open and unmerged until we do so, so we do not forget.

@luzpaz
Copy link
Author

luzpaz commented Sep 7, 2021

which upstream repos specifically? I can make PRs to them if you want

@falkTX
Copy link
Contributor

falkTX commented Sep 7, 2021

Since nanovg is not maintained anymore, and the pugl changes here are related to old unused files, the only remaining ones are RtAudio and LV2.
https://github.com/thestk/rtaudio/
https://github.com/lv2/lv2

@luzpaz
Copy link
Author

luzpaz commented Sep 7, 2021

@falkTX
rtaudio: upstream has already fixed these typos. The forked files in this repo are outdated.
lv2: PR submitted: lv2/lv2#58

@falkTX
Copy link
Contributor

falkTX commented Sep 7, 2021

ah great, thanks for that.
I will need to sort out updating of these files, to be done soon.

Found via `codespell -q 3 -S ./dgl/src/pugl-upstream`
@falkTX falkTX force-pushed the develop branch 2 times, most recently from 59cc6ed to 470c5b7 Compare July 14, 2024 11:06
@falkTX falkTX force-pushed the develop branch 8 times, most recently from 8507aec to 7cd4819 Compare October 6, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants