Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 4ms modules #763

Closed
wants to merge 1 commit into from
Closed

adding 4ms modules #763

wants to merge 1 commit into from

Conversation

dromer
Copy link
Collaborator

@dromer dromer commented Nov 26, 2024

Will need quite some custom work.

Also noticed that there is some networking code, but not sure if that also runs in the VCV module itself or it's only for the Meta eurorack module.

@dromer dromer marked this pull request as draft November 26, 2024 14:11
@dromer dromer changed the title first basics for adding 4ms adding 4ms modules Nov 26, 2024
@falkTX
Copy link
Contributor

falkTX commented Nov 26, 2024

seems like this needs c++17 too

@dromer
Copy link
Collaborator Author

dromer commented Nov 26, 2024

C++20 even? 🤔

4ms/lib/CoreModules/4ms/4ms_element_state_conversions.hh:13:66: error: ‘requires’ only available with ‘-std=c++20’ or ‘-fconcepts’

@falkTX
Copy link
Contributor

falkTX commented Nov 26, 2024

could be, but then I dont think they are building with the regular Rack toolchain which would be a problem.
but well we can just check the source...

https://github.com/4ms/4ms-vcv/blob/main/CMakeLists.txt#L5 says C++20 😞

We can try to build with C++17, but if it fails it is best to give up.

@falkTX
Copy link
Contributor

falkTX commented Nov 26, 2024

Yeah they have this nasty thing in there https://github.com/4ms/4ms-vcv/blob/main/RackSDK.cmake#L43

Their CI uses a custom docker image based on the Rack SDK, for getting gcc-13
qno/rack-plugin-toolchain@v2...4ms:rack-plugin-toolchain:v2

No point on trying here, I am closing the PR as this is not mergeable.

@falkTX falkTX closed this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants