Fix MULTIPOLYGON quote handling in PFS parser #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced in the PFS rewrite where MULTIPOLYGON strings would accumulate quotes on each read-write cycle. The MULTIPOLYGON special case (added for performance, see issue #749) was returning the raw value_str without stripping quotes. This caused: - First read: Shape = 'MULTIPOLYGON...' (quote preserved) - After write-read: Shape = ''MULTIPOLYGON...' (quote doubled) The fix maintains the performance optimization (25x faster than v2.6.0) while properly stripping quotes like other string values. Performance benchmarks (multipolygon.pfs): - v2.6.0 (YAML): 110ms - v3.0.0 (buggy): 6.0ms - Current fix: 4.4ms ✓ Added comprehensive regression test: test_multipolygon_quote_handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression bug in v3.0.0 (#866) where MULTIPOLYGON strings accumulate quotes on each read-write cycle.
The MULTIPOLYGON special case (added for performance in the PFS rewrite, related to issue #749) was returning raw strings without stripping quotes, causing:
'MULTIPOLYGON...'(quote preserved)''MULTIPOLYGON...'(quote doubled)Solution
Modified the MULTIPOLYGON fast path to strip quotes like other string values while maintaining the performance optimization.
Testing the fix
Users can install this branch to test the fix:
Or with uv: