Feature/473710 Common Data Integration #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing required... Tests Required....
JulianYoungEviden
changed the title
Pending Unit tests and integration tests
…CommonData-Integration
Refactored OrganisationRegistrationSubmissionService to take the Synchronisation code out of the main file
Repaired some assignments of dates and statuses
Added support for non-compliant date-parsing
…OrganisationRegistrationEvents]
…-facade into feature/473710-CommonData-Integration
- Amended the sort order of Cosmos events - Ensure Registration Reference Num is not overwritten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection to CommonData
This PR adds connection to the CommonData API, removing the Test Data from the solution.
New DTO classes are added to receive the data from CommonData and changes are made to the Response to the front-end.
Tests are present.
The CSO Paycal JSON from Common Data is translated to a new DTO as part of the Response object.