-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serve Gottschalk images from prod server #826
Serve Gottschalk images from prod server #826
Conversation
cantaloupe/interim_files/manifests/gottschalk_manifest_w_lacunae.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not at all an expert IIIF manifests, but if the change is to replace staging.simssa.ca
with simssa.ca
in this entire file, I trust your text editor to have not missed anything. So I'll give my approval for now, but I do think @ahankinson's suggestion makes sense, so probably update that before merging.
Also, visiting |
There is nothing on the other end of this (ie. there is no |
The latest commit addresses Andrew's comment. I'm going to merge to make sure at least this change works, but let's continue the discussion. |
Then it's not IIIF. The base of the URI must resolve to an info.json response -- that's how image viewers find out how many zoom levels there are, tile sizes, etc. Section 5: https://iiif.io/api/image/3.0/#5-image-information
Canteloupe should generate the info.json automatically, so you don't need to write it by hand. You have a canteloupe response that is looking for the info.json, but it's not configured correctly. Changing it to |
Ah, ok. Then yes, just a configuration issue. The extra |
This PR updates the CU-hosted manifest for the Gottschalk reconstruction to serve images from production rather than staging. With Release 3.2-0.12.0 (https://github.com/DDMAL/cantus/releases/tag/v.3.2-0.12.0) these images are on prod, so we can serve them from prod for both staging and production purposes.