Update bootstrap 5 #1725
Merged
Update bootstrap 5 #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Format the html for these pages.
Add test mix-in to support formatted templates.
A request object is not sent to the `BadRequest` exception, so we check whether such an object exists before trying to render the `400.html` template.
When I pull the branch and collect static pages it looks like this. Is that what you're seeing as well? |
|
Hmm...that's not what I have. Here's what I get:
Try doing a hard refresh of the page? Edit: When you look at those links on the side in the developer tools, where is the styling coming from? For example, there should be color styles coming from |
|
Hard refresh fixed it! Not sure what was going on, but the css styling was fixed as well. |
lucasmarchd01
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the version of Bootstrap used in CantusDB to Bootstrap 5. Closes #1462.
This PR touches many many files, but most of those changes are cosmetic and/or involve replacing deprecated Bootstrap classes with new ones. I suspect the best way to review is going to be to pull this branch and walk through pages locally. Note: static files must be refreshed!
A few other minor additions to this PR:
djlintdocker-compose-development.ymlfile was rewritten to not require a pin for debugging withrunserver_plus. Since this command is only ever run locally, we don't need the security of a pin.assertParsedContains, that maps closely to Django'sassertContainsmethod, but, by parsing the html, is more robust to these types of changes to html that do not impact rendered html. The additional ofBeautifulSoupandlxmldev dependencies are used for this assertion; however, no production dependencies are added!Also closes #1721.