Chant Detail: Reimplement concordances #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create API view to proxy requests for Cantus ID concordances to Cantus Index and Gregorien.info (proxy required due to CORS configuration on Cantus Index). Update chant_detail.js to parse and display concordances. Add tests for concordances. Remove extraneous container classes in `base.html` and `base_page_with_side_cards.html`.
lucasmarchd01
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplements concordances on the Chant Detail page. Requests for concordances are proxied through a view in
views/api.pyto account for CORS configuration on Cantus Index.Concordances are fetched on user click. Both a summary and detail table are shown (see screenshot). The detail table can be hidden for ease of navigation around the page. No other table navigation (sorting, etc.) is included in this PR...perhaps this could be a future enhancement.
Initial Chant Detail page
Chant Detail page when "Display the concordances..." is clicked
Chant Detail page when no concordances exist
Relevant tests are added.
Adds the
djlintdependency for linting/formatting of Django templates.Closes #1389.