-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement proofread filter functionality to Browse Chants page #1706
Conversation
- manuscript_full_text_proofread, manuscript_full_text_std_proofread, volpiano_proofread - check if user is proofreader - add form for proofread choicefields
- Handling of manuscript full text, volpiano, and proofreading filters
- add proofread filters
Just adding another thought here... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's here look good, but I think it would be to not close #1492 yet, because what's here is useful for seeing what chants in a source need proofreading, but you have to know which sources have these chants to make it useful. I'm not sure if that's always the case? Maybe @annamorphism can let us know based on experience. If it's helpful to see this at the source level too, we may want to add a similar function to the Source List page.
@dchiller yes, it's not always known at the source level if a source is "done" or not--for example, I know I've proofread some fragments from Trier and not others. This way I can go in and check, but a little flag that "this source has some chants that need proofreading" would help find them. |
Co-authored-by: Dylan Hillerbrand <[email protected]>
…into issue-1492
This PR introduces functionality for filtering by proofreading status on the "Browse Chants" page. It includes:
manuscript_full_text_proofread
,manuscript_full_text_std_proofread
, andvolpiano_proofread fields
.Updated screenshot:
Towards #1492