Put view classes in separate files #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahankinson
reviewed
Jul 16, 2024
- update urls.py with api view imports - directly import redirect views
dchiller
force-pushed
the
split-views-files
branch
from
a23ac41 to
6ad61db
Compare
dchiller
force-pushed
the
split-views-files
branch
from
915eee9 to
ad35080
Compare
dchiller
force-pushed
the
split-views-files
branch
from
aa870ed to
c121369
Compare
lucasmarchd01
approved these changes
Jul 25, 2024
67 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1533.
This PR distributes view previously in
views/views.pyinto:api.py: Contains any "api" views (views with responses that are not rendered and don't fit into redirect or autocomplete view categories)auth.py: Contains the "change password" viewautocomplete.py: Contains views used in the implementation of autocomplete fieldscontact.py: Contains a view for the contact flatpageredirect.py: Contains redirect viewssite_stats.py: Contains views for the "item count" and "content overview" pagesFor the future, it probably makes sense to manage the contact page with the flatpages app. I've added this as a low priority issue #1572.