Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make necessary changes for Python 3 in joint_control #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kaka012
Copy link
Contributor

@kaka012 kaka012 commented Nov 17, 2021

The changes have intentionally been kept minimal to make them easier to verify. The Notebooks would likely benefit from a re-run afterwards though, to upgrade their internal version numbers.

The fixes are as follows:

  • print(data) instead of print data, as print became a function in Python 3 instead of a keyword. Also f-Strings have been used, assuming a non-EOL-Python (supported since 3.6), since they are shorter than a .format().
  • open(filename, 'rb') for pickle.load since the latter requires a function returning bytes instead of strings so the file has to be opened in binary mode.
  • The imports in init.py have to be changed to be relative to the base module name. Otherwise just a ModuleNotFoundError: No module named 'hello' results.
  • In sexpr.py the import future has been dropped since it is obsolete and unused and the shebang has been dropped since the file has no main function.
  • In learn_posture.ipynb it has been noticed, that the listdir()-Function returns a list in arbitrary (undefined and may change from run to run) order. This has been resolved by simply sorting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant