Skip to content

Conversation

@lzjqsdd
Copy link
Member

@lzjqsdd lzjqsdd commented Jul 5, 2025

No description provided.

@lzjqsdd lzjqsdd requested a review from Copilot July 5, 2025 01:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR syncs the compile Docker image workflow to Docker Hub and adjusts the Dockerfile’s Rust setup.

  • Dockerfile changes: added commented mirror ENV lines and pinned the Rust toolchain to 1.86.0
  • CI workflow changes: added a Docker Hub login step and updated tags to push the image to Docker Hub

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
curvine-docker/compile/Dockerfile_rocky9 Uncommentable mirror ENV lines & pin Rust default to 1.86.0
.github/workflows/build-docker-image.yml Added Docker Hub login step and updated image tagging
Comments suppressed due to low confidence (1)

.github/workflows/build-docker-image.yml:48

  • Only tagging 'latest' makes rollbacks and debugging harder; consider also tagging with github.sha or a version number to provide immutable image references.
            lzjqsdd/curvine-compile:latest

Comment on lines 30 to +31
source $HOME/.cargo/env && \
rustup default stable
rustup default 1.86.0
Copy link

Copilot AI Jul 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Pinning the Rust toolchain to 1.86.0 may become outdated; consider using the 'stable' channel or document why a fixed version is required to prevent drift.

Copilot uses AI. Check for mistakes.
Comment on lines +25 to 28
# uncomment the following two lines if you met network problem
#ENV RUSTUP_UPDATE_ROOT=https://mirrors.aliyun.com/rustup/rustup
#ENV RUSTUP_DIST_SERVER=https://mirrors.aliyun.com/rustup
ENV PATH="/root/.cargo/bin:${PATH}"
Copy link

Copilot AI Jul 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Rather than leaving mirror variables commented out, consider turning these into ARGs so users can enable alternate dist servers via build arguments without editing the Dockerfile.

Suggested change
# uncomment the following two lines if you met network problem
#ENV RUSTUP_UPDATE_ROOT=https://mirrors.aliyun.com/rustup/rustup
#ENV RUSTUP_DIST_SERVER=https://mirrors.aliyun.com/rustup
ENV PATH="/root/.cargo/bin:${PATH}"
# Allow users to specify alternate Rust distribution servers via build arguments
ARG RUSTUP_UPDATE_ROOT=https://mirrors.aliyun.com/rustup/rustup
ARG RUSTUP_DIST_SERVER=https://mirrors.aliyun.com/rustup
ENV RUSTUP_UPDATE_ROOT=${RUSTUP_UPDATE_ROOT} \
RUSTUP_DIST_SERVER=${RUSTUP_DIST_SERVER} \
PATH="/root/.cargo/bin:${PATH}"

Copilot uses AI. Check for mistakes.
@lzjqsdd lzjqsdd merged commit 47a2f83 into main Jul 5, 2025
3 checks passed
@bigbigxu bigbigxu deleted the sync-image branch July 25, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants