Conversation
github-actions
bot
added
A-workspace
Boog900
reviewed
May 13, 2025
| } | ||
| } | ||
|
|
||
| pub fn dry_run_check(args: &Args) { |
Member
There was a problem hiding this comment.
I think to reduce duplicated code it would be better to call this function in read_config_and_args after the config is loaded there and not in do_quick_requests where it currently is
| time::Duration, | ||
| }; | ||
|
|
||
| use args::Args; |
Member
There was a problem hiding this comment.
nit: because the is a mod and not an external crate it should be grouped with the mod imports around line 40
hinto-janai
added
the
C-feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding cuprated --dry-run option
What
adding of command line option --dry-run
Why
to verify config file parameters :
Config deserialization
PATH permissions
If ports can be binded to
Where
the modifications are in config.rs where we create:
a check_port() function which check if the port is available or not
a dry_run_check() function which look for the config file .toml or take the default config and check the deserialization, path permissions and availability of ports by calling check_port() function
and in arg.rs where we add the dry_run argument and call the dry_run_check() function