cuprated: P2P protocol request handler #303
Conversation
| let BlockChainContextResponse::Context(context) = blockchain_context_service | ||
| .ready() | ||
| .await | ||
| .expect(PANIC_CRITICAL_SERVICE_ERROR) | ||
| .call(BlockChainContextRequest::Context) | ||
| .await | ||
| .expect(PANIC_CRITICAL_SERVICE_ERROR) | ||
| else { | ||
| unreachable!() | ||
| }; |
There was a problem hiding this comment.
From #308 (review):
binaries/cuprated/src/rpc/request/*.rs which are fn versions of our tower::Service's Request -> Response to reduce noise
Since cuprated will be using Services like this in general, should I move this folder? Maybe cuprated/src/service/*.rs? I think this will reduce noise significantly through cuprated, example here would be:
let context = blockchain_context::context(&mut blockchain_context_service)
.await
.expect(PANIC_CRITICAL_SERVICE_ERROR)
.unchecked_blockchain_context();There was a problem hiding this comment.
I have plans to rework this service to make getting the context not require a Service request, so for now I don't think so.
There was a problem hiding this comment.
Reasoning for 83a3626
boog900: hinto: can we disable the
rust-2024-compatibilitylint: https://github.com/Cuprate/cuprate/actions/runs/12142669672/job/33857710159
hinto: I forgot our docs were nightly, yes btw maybe in #303?
boog900: sure
What
Implements the P2P protocol handler