Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required Status fields and conditions to Job objects in tests. #4066

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

dsessler7
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

Some of our tests currently fail in k8s 1.32 due to changes in required fields on batchv1.Job objects.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Added the required fields and conditions to the Job objects we create in our tests so that our tests pass.

Other Information:

@dsessler7 dsessler7 merged commit 4454815 into CrunchyData:main Jan 6, 2025
17 checks passed
@dsessler7 dsessler7 deleted the add_fields_to_jobs_in_tests branch January 6, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants