-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Changesets support #84
Conversation
122c2d0
to
7acf12c
Compare
🦋 Changeset detectedLatest commit: 5b49970 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7acf12c
to
632ffa4
Compare
@@ -10,11 +10,16 @@ | |||
"test": "pnpm --filter test-app test", | |||
"lint": "pnpm --filter '*' lint", | |||
"lint:fix": "pnpm --filter '*' lint:fix", | |||
"ci:update": "npx ember-ci-update" | |||
"ci:update": "npx ember-ci-update", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, what what is this???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of my attempts to make managing the big ci.yml in .github/workflows/ easier.
One thng it still does nicely ds keep your ember-try config in sync with CI.
The main thing is that when this was made, each job required 10 or so lines of setup, and it was rually overwhelming
I've since abandoned it as i've learned about:
- in-repo custom actions
- actual custom actions published to the market place.
I now use wyvox/action@v1 in new workflows, and NullVoxPopuli/action-setup-pnpm@v2 where i want more control back.
This has the desired effect of making the workflow files way less overwhelming while also providing something that ds easier to maintain .
For wyvox/action, i've been meaning to add the turbo server to it, but haven't gotten around to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting with: wyvox/action#1
it now supports turborepo.
Example workflow: https://github.com/NullVoxPopuli/v2-addon-project-template/blob/main/.github/workflows/ci.yml
02ef4bc
to
5b49970
Compare
Description
This PR moves to using Changesets over semantic-release. The reason here is so that the repos we work in most frequently use the same tooling so that we have similar DX across all projects. The following projects use changesets:
ember-toucan-core
ember-headless-form
ember-headless-table
tailwind-toucan-base
ember-toucan-styles
This should roughly match this PR.