Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changesets support #84

Merged
merged 5 commits into from
May 30, 2023
Merged

Add Changesets support #84

merged 5 commits into from
May 30, 2023

Conversation

ynotdraw
Copy link
Contributor

@ynotdraw ynotdraw commented May 24, 2023

Description

This PR moves to using Changesets over semantic-release. The reason here is so that the repos we work in most frequently use the same tooling so that we have similar DX across all projects. The following projects use changesets:

This should roughly match this PR.

@ynotdraw ynotdraw changed the title Changesets support Add Changesets support May 24, 2023
@ynotdraw ynotdraw self-assigned this May 24, 2023
Base automatically changed from fix-main to main May 25, 2023 14:46
@changeset-bot
Copy link

changeset-bot bot commented May 25, 2023

🦋 Changeset detected

Latest commit: 5b49970

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ember-velcro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -10,11 +10,16 @@
"test": "pnpm --filter test-app test",
"lint": "pnpm --filter '*' lint",
"lint:fix": "pnpm --filter '*' lint:fix",
"ci:update": "npx ember-ci-update"
"ci:update": "npx ember-ci-update",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, what what is this???

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of my attempts to make managing the big ci.yml in .github/workflows/ easier.
One thng it still does nicely ds keep your ember-try config in sync with CI.

The main thing is that when this was made, each job required 10 or so lines of setup, and it was rually overwhelming

I've since abandoned it as i've learned about:

  • in-repo custom actions
  • actual custom actions published to the market place.
    I now use wyvox/action@v1 in new workflows, and NullVoxPopuli/action-setup-pnpm@v2 where i want more control back.

This has the desired effect of making the workflow files way less overwhelming while also providing something that ds easier to maintain .

For wyvox/action, i've been meaning to add the turbo server to it, but haven't gotten around to it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ynotdraw ynotdraw merged commit 4410428 into main May 30, 2023
@ynotdraw ynotdraw deleted the changesets-support branch May 30, 2023 15:23
@github-actions github-actions bot mentioned this pull request May 30, 2023
@github-actions github-actions bot mentioned this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants