Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix main branch typescript errors #83

Merged
merged 12 commits into from
May 25, 2023
Merged

chore: Fix main branch typescript errors #83

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
6df8e5a
chore: Upgrade glint dependencies
ynotdraw May 17, 2023
ca5e123
chore: Allow any ember-source + typescript
ynotdraw May 17, 2023
005290f
chore: Glint only supports TSv4.8+
ynotdraw May 17, 2023
7c54006
chore: Upgrade ember-source + resolver
ynotdraw May 17, 2023
3690063
chore: Remove commitlint
ynotdraw May 17, 2023
28761d7
chore: Update babel/core + qunit deps
ynotdraw May 19, 2023
2b6ed5b
chore: Add @types/ember__owner dependency
ynotdraw May 19, 2023
ad8da94
chore: Add ember/string as a dependency for tests
ynotdraw May 19, 2023
6ae7b64
chore: Ignore glint errors for now
ynotdraw May 22, 2023
c399620
chore: Convert tests to gts
ynotdraw May 22, 2023
126348c
fix: Remove unneeded peerDependencies
ynotdraw May 24, 2023
370cb3b
fix: Remove unneeded types/ember packages
ynotdraw May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,20 +37,6 @@ jobs:
run: pnpm lint



commits:
name: Commit Messages
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: ./.github/actions/pnpm
- uses: wagoid/[email protected]
with:
configFile: 'commitlint.config.cjs'


build:
name: Build Tests
needs: [install_dependencies]
Expand All @@ -72,9 +58,8 @@ jobs:
fail-fast: true
matrix:
typescript-scenario:
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
Copy link
Contributor Author

@ynotdraw ynotdraw May 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glint requires typescript >= 4.8. We had a similar PR here


steps:
- uses: actions/checkout@v3
Expand All @@ -89,7 +74,6 @@ jobs:
pnpm --filter test-app exec glint --version;
pnpm --filter test-app exec glint;




default_tests:
Expand Down
15 changes: 7 additions & 8 deletions ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@ template: "v2-addon"

# ---------------------

addon: './ember-velcro'
testApp: './test-app'
addon: "./ember-velcro"
testApp: "./test-app"

# https://github.com/pnpm/pnpm/issues/4965
fixes: ['pnpm#4965']
fixes: ["pnpm#4965"]

lint:
commits: true
cmd: 'pnpm lint'
cmd: "pnpm lint"

build:
run: 'pnpm build'
run: "pnpm build"
expect: |
index.js
index.js.map
Expand All @@ -26,9 +26,8 @@ support:
ember-try: true
glint: true
typescript:
- "[email protected]"
- "[email protected]"
- "[email protected]"
- "[email protected]"
- "[email protected]"

release:
semantic: true
33 changes: 0 additions & 33 deletions commitlint.config.cjs
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and deleted this as our other repos are no longer including this due to the move to changesets where we can control releases and commits can be squashed with helpful messages anyway. Getting errors in CI about commits is really tough, especially when the error messages aren't helpful at all.

We don't want to create a release just yet using semantic-release anyway, as there's still more to do to get this completely functional with toucan-core + Glint in general for external consumers. For example, we'll need to add an exported template-registry. I plan on doing this right after this PR merges, as I want to keep PRs as small as possible so they're easier to follow.

This file was deleted.

10 changes: 5 additions & 5 deletions ember-velcro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
"prepack": "rollup --config ./rollup.config.js"
},
"peerDependencies": {
"@glint/environment-ember-loose": "^0.9.4",
"@glint/template": "^0.9.5"
"@glint/environment-ember-loose": "^1.0.2",
"@glint/template": "^1.0.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR didn't change this, but I wonder why we have these as peer deps? Other similar addons with Glint support don't have this, same for the addon blueprint. At least they should be optional, as non-TS shouldn't be force to install them. But I think it should be enough to have them as devDeps!?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I agree here, nice call out. This should be resolved now with the latest commit

},
"dependencies": {
"@embroider/addon-shim": "^1.0.0",
Expand All @@ -62,16 +62,16 @@
"ember-modifier": "^3.2.7"
},
"devDependencies": {
"@babel/core": "^7.19.3",
"@babel/core": "^7.21.0",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-proposal-decorators": "^7.19.3",
"@babel/preset-typescript": "^7.18.6",
"@babel/runtime": "^7.19.4",
"@embroider/addon-dev": "^2.0.0",
"@glimmer/component": "^1.1.2",
"@glimmer/tracking": "^1.1.2",
"@glint/environment-ember-loose": "^0.9.5",
"@glint/template": "^0.9.5",
"@glint/environment-ember-loose": "^1.0.2",
"@glint/template": "^1.0.2",
"@nullvoxpopuli/eslint-configs": "^2.2.58",
"@rollup/plugin-babel": "^5.3.1",
"@semantic-release/changelog": "^6.0.0",
Expand Down
Loading