Skip to content

url_display: correctly display v6 addresses #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gittiver merged 2 commits into from
Sep 22, 2025
Merged

url_display: correctly display v6 addresses #1096

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83516d2
url_display: correctly display v6 addresses
Sep 20, 2025
5540ec3
removed & as address is returned by value
gittiver Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/crow/socket_acceptors.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ namespace crow
}
std::string url_display(bool ssl_used) const
{
return (ssl_used ? "https://" : "http://") + acceptor_.local_endpoint().address().to_string() + ":" + std::to_string(acceptor_.local_endpoint().port());
auto& address = acceptor_.local_endpoint().address();
return (ssl_used ? "https://" : "http://") + (address.is_v4() ? address.to_string() : "[" + address.to_string() + "]") + ":" + std::to_string(acceptor_.local_endpoint().port());
}
tcp::acceptor& raw_acceptor()
{
Expand Down
Loading